Lazyweb results: code review and git.

Here's a summary of the e-mail responses I got to my lazyweb query re code review and git.

A few people (Paul Nasrat and Jeff Balogh) pointed out that Review Board supports git. So I may try that.

Charles McCreary has had good experience with Rietveld, but I don't think that it has mature git integration -- although git-cl looks interesting. However, from what I understand git-cl works in tandem with svn, letting you associate git patches with particular Rietveld issues and then commit them to svn. Since we're eschewing svn completely, that might not work well.

Jeff Balogh also discussed Gerrit a bit, and suggested I try it; it's an adaptation of Rietveld to support git.

Jeff also pointed me towards some great resources: Alex Martelli's Code Reviews for Fun and Profit and some launchpad (?) discussion on a mailing list about how to make code reviews work better.

Jeff's other words of wisdom for code reviews:

  • ask lots of questions, but be prepared for blowback from people that think you're being a jerk.
  • get as many people involved in code reviews as possible, as soon as possible, or else you might get stuck being the "code review" person.

Finally, Andriy Khavryuchenko pointed me towards his new startuplet, -- blog post here. This is a "code discussion" service that seems like it would integrate well with a lightweight git-based code review approach. I may bug him about an opportunity to beta test reviework once I actually have some experience with code review...

Thanks, everyone! I'll be sure to post about how the code reviews go.


Legacy Comments

Posted by Gregg Sporar on 2008-12-26 at 13:55.

To a certain extent, it's **how** you ask a question during code
review that influences whether people think you are being a jerk.  For
example, instead of asking "why did you use method x()..." ask "by
using method x(), what did you have in mind?"  More tips here: <a href

Comments !